This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Add email body template & Optimize notification setting UI #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,7 +97,6 @@ export function EditReportDefinition(props) { | |||
|
|
|||
| const callUpdateAPI = async (metadata) => { | |||
| const { httpClient } = props; | |||
|
|
|||
There was a problem hiding this comment.
Can we remove this file from the PR?
There was a problem hiding this comment.
do you mean edit_report_definition.tsx
There was a problem hiding this comment.
Yeah- it looks like the only change is an empty line removal?
| @@ -143,13 +142,12 @@ export const channelSchema = schema.object({ | |||
| }), | |||
| { minSize: 1 } | |||
| ), | |||
| // TODO: consider add this field next to url-related fields. | |||
| // Need this to build the links in email | |||
| origin: schema.uri(), //e.g. https://xxxxx.com | |||
There was a problem hiding this comment.
Do we need input validation for this?
There was a problem hiding this comment.
the .uri() will check whether it is valid uri in this format https://xxxxx.com
| ); | ||
| /** | ||
| * notification plugin response example: | ||
| * { |
There was a problem hiding this comment.
Can we remove this comment block?
davidcui1225
approved these changes
Oct 23, 2020
anirudha
approved these changes
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
update notification settings UI and flow behind in create report definition
Add email template
update notification setting UI in report details page
Add better logging and error handling for email
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.