This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
use session cookie for puppeteer to access url of security-enabled domain #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
joshuali925,
davidcui1225,
akbhatta and
abbashus
| */ | ||
| return; | ||
| } | ||
| // else if (triggerType == TRIGGER_TYPE.alerting) { |
There was a problem hiding this comment.
np: I think we can get rid of the commented-out else if block since there is a TODO statement
| return res; | ||
| } else if (triggerType == TRIGGER_TYPE.onDemand) { | ||
| /* | ||
| * TODO: return nothing for on Demand report, because currently on-demand report is handled by client side, |
There was a problem hiding this comment.
What's the TODO here? It looks like we already return nothing for on-demand report?
davidcui1225
approved these changes
Oct 21, 2020
akbhatta
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
kibana-reports/server/routes/utils/visualReportHelper.ts.security_authenticationpage.setCookie(cookie)beforepage.goto(queryUrl)createReport.ts,deliverReport.ts,createScheduleReport.ts,visualReportHelper.tsfromreportHelper.ts. Remove reportHelperscreateSchedulefromreportDefinition.tsand create a new filecreateSchedule.tshelpers.tsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.