This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Improve server side input validation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ export const addReportsTableContent = (data) => { | |||
| //TODO: wrong name | |||
| timeCreated: report.time_created, | |||
| state: report.state, | |||
| url: report.query_url, | |||
| url: `${location.host}${report.query_url}`, | |||
There was a problem hiding this comment.
What does location.host add?
There was a problem hiding this comment.
the query_url is now relative, need to add the host as well for the link rendered in report table -> report source field to be accessible.
| @@ -27,32 +29,56 @@ import { | |||
| } from '../routes/utils/constants'; | |||
|
|
|||
| export const dataReportSchema = schema.object({ | |||
| base_url: schema.uri(), | |||
| base_url: schema.string({ | |||
| validate(value) { | |||
There was a problem hiding this comment.
If the validation fails will this still return an error to the client-side and trigger the error toasts in the UI?
There was a problem hiding this comment.
It will, it will also include the error message
davidcui1225
approved these changes
Oct 19, 2020
akbhatta
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#90
Description of changes:
url: pass relative url instead of full url, compose url on server side wiht
localhost:5601text fields: validate non-empty.
report Name: validate allowed characters using regexemail recipients: validate email address formattimestamp fields: validate positive number
cron-expression: validate unix cron-expression (5 digits)
time duration: validate ISO format for time duration. e.g.
PT10M(10 mintues)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.