This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
lazy load efSearch #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
reviewed
Feb 16, 2020
| @@ -236,4 +236,8 @@ public void onFileDeleted(Path indexFilePath) { | |||
| getInstance().cache.invalidate(indexFilePath.toString()); | |||
| } | |||
| }; | |||
|
|
|||
| private String[] getQueryParams(String indexName) { | |||
| return new String[] {"efSearch=" + KNNSettings.getEfSearchParam(indexName)}; | |||
There was a problem hiding this comment.
Could you explain more why there is only 1 query parameter being passed in? Why are M and efConstruction not gotten?
There was a problem hiding this comment.
efSearch is required only during searches. Other algorithm params are needed for indexing.
| @@ -87,12 +87,6 @@ public long getIndexSize() { | |||
| public void close() { | |||
| Lock writeLock = readWriteLock.writeLock(); | |||
| writeLock.lock(); | |||
|
|
|||
There was a problem hiding this comment.
Why is this no longer needed?
There was a problem hiding this comment.
Good catch. Bad merge. Will add it back.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#51
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.