This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#279
Description of changes:
This PR fixes a build failure when using CMake >= 3.18. During the build process, we use
find_path
to check if the nmslib submodule has already been pulled. If it has not, we pull it (in line 37). Recently, Ubuntu 18 in Github actions upgraded from Cmake 3.17 to 3.19.For some reason, I added the REQUIRED parameter in find_path. This had no effect in Cmake < 3.18. In Cmake >= 3.18, this causes CMake process to fail: https://cmake.org/cmake/help/v3.18/command/find_path.html. So, the fix is to remove REQUIRED parameter.
I verified the change works for CMake 3.19 on Ubuntu 18. I also verified that the fix does not break functionality for 3.17 on my Mac.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.