This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add stats for custom scoring feature #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Sep 21, 2020
| /** | ||
| * Test checks that script stats are properly updated | ||
| */ | ||
| public void testScriptStats() throws Exception { |
There was a problem hiding this comment.
Can we add similar test with multiple shards?
vamshin
reviewed
Sep 21, 2020
| #### script_query_requests | ||
| The number of query requests that use the k-NN score script. | ||
|
|
||
| #### script_query_errors |
There was a problem hiding this comment.
I think these errors are counted at shard level. We could update the documentation accordingly. Also you might want to check if all the above metrics at shard level or index level
There was a problem hiding this comment.
Yes, they are at shard level. I updated README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a few statistics for custom scoring feature. The following statistics are added:
script_compilations
The number of times the knn script is compiled. This value should only be 0 or 1 most of the time. However, if the cache containing the compiled scripts is filled, it may cause the script to be recompiled.
script_compilation_errors
The number of errors during script compilation.
script_query_requests
The number of query requests that use the k-NN score script.
script_query_errors
The number of errors that have occurred during use of the k-NN score script.
Along with adding the stats, I updated the README and added another stats integration test to verify the changes.
I think in the future, it will probably make sense to refactor the stats api into different sections for custom scoring and approximate k Nearest Neighbor search. I will create an issue to do this.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.