Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change "space" parameter to "space_type" for custom scoring #232

Conversation

jmazanec15
Copy link
Member

Issue #, if available:

Description of changes:
For Approximate k-NN search, we use "space_type" to specify the space for the index. For custom scoring search, we use the parameter "space". To maintain consistency and prevent confusion, this PR changes the parameter "space" to "space_type" for custom scoring.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Enhancements Improvement on existing component label Sep 21, 2020
@jmazanec15 jmazanec15 requested a review from vamshin September 21, 2020 16:45
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     78.51%   78.51%           
  Complexity      335      335           
=========================================
  Files            53       53           
  Lines          1308     1308           
  Branches        121      121           
=========================================
  Hits           1027     1027           
  Misses          228      228           
  Partials         53       53           
Impacted Files Coverage Δ Complexity Δ
...search/knn/plugin/script/KNNVectorScoreScript.java 77.77% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3199583...37f3b1c. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@jmazanec15 jmazanec15 merged commit ee16162 into opendistro-for-elasticsearch:master Sep 21, 2020
@jmazanec15 jmazanec15 deleted the cs-rename-space-to-space-type branch September 21, 2020 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancements Improvement on existing component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants