Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add AWS CLI in order to ship library artifacts from container #194

Merged

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#169

Description of changes:
Because we now build and ship library artifacts from Centos container, we need to manually install the AWS CLI in the container. Verified that this installation works on Centos 7.

Related to test Github action failure: https://github.com/opendistro-for-elasticsearch/k-NN/runs/951599939?check_suite_focus=true

Documentation for installing AWS CLI on linux: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 requested a review from vamshin August 6, 2020 00:13
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
  Complexity      307      307           
=========================================
  Files            49       49           
  Lines          1141     1141           
  Branches        100      100           
=========================================
  Hits            894      894           
  Misses          198      198           
  Partials         49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d1985...317ee7c. Read the comment docs.

@vamshin
Copy link
Member

vamshin commented Aug 6, 2020

Why do we need AWS cli?

@jmazanec15
Copy link
Member Author

@vamshin we need it because we use it to copy the built artifacts to S3 here. The Centos container used for building the artifacts does not come with it, like the Github Actions Ubuntu runner.

@jmazanec15 jmazanec15 merged commit 54b1508 into opendistro-for-elasticsearch:master Aug 6, 2020
@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants