Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Codecov configuration to set a coverage threshold to pass the check on a commit #192

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#191

Description of changes:
Adding a check that makes sure code coverage does not drop below 70% or does not drop 1% for tests.

Reference PR
opendistro-for-elasticsearch/index-management#251

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 requested a review from vamshin August 3, 2020 23:39
@jmazanec15 jmazanec15 changed the title add code coverage check Add code coverage check Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     78.35%   78.35%           
  Complexity      307      307           
=========================================
  Files            49       49           
  Lines          1141     1141           
  Branches        100      100           
=========================================
  Hits            894      894           
  Misses          198      198           
  Partials         49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538278a...f9ae4ec. Read the comment docs.

@jmazanec15 jmazanec15 changed the title Add code coverage check Add Codecov configuration to set a coverage threshold to pass the check on a commit Aug 3, 2020
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 merged commit f7d1985 into opendistro-for-elasticsearch:master Aug 4, 2020
@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants