This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Reset state for uTs so tests run independently #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
changed the title
chenqi0805
added a commit
to chenqi0805/k-NN
that referenced
this pull request
Jul 15, 2020
…asure * master: FIX: Pass -march=x86-64 to build JNI library (opendistro-for-elasticsearch#164) FIX: Added resetState for uTs so state does not spill over (opendistro-for-elasticsearch#159)
jmazanec15
changed the title
jmazanec15
added a commit
to jmazanec15/k-NN
that referenced
this pull request
Aug 12, 2020
jmazanec15
added a commit
that referenced
this pull request
Aug 12, 2020
jmazanec15
changed the title
jmazanec15
added
Infrastructure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#158
Description of changes:
Test cases were failing because the state from the KNNIndexCache (singleton) was spilling over from other test cases. This PR prevents this by adding a tearDown method which resets counter, clears out the cache, and closes the cache.
In order to test, I replicated the failure on an Ubuntu 16 machine. Then, with the change, it passes. Additionally, I tested the change on a Mac. I was not able to reproduce the failure, but, with the fix,
./gradlew buildstill passes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.