Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix release notes versioning #157

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Fix release notes versioning #157

merged 2 commits into from
Jul 1, 2020

Conversation

vamshin
Copy link
Member

@vamshin vamshin commented Jul 1, 2020

Issue #, if available:
#156

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vamshin vamshin requested a review from jmazanec15 July 1, 2020 20:45
jmazanec15
jmazanec15 reviewed Jul 1, 2020
View reviewed changes
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the headers need to be changed, no?

https://github.com/opendistro-for-elasticsearch/k-NN/pull/157/files#diff-1d11f9292729549ade829dcd46bbb84aR1

@vamshin
Copy link
Member Author

vamshin commented Jul 1, 2020

I believe the headers need to be changed, no?

https://github.com/opendistro-for-elasticsearch/k-NN/pull/157/files#diff-1d11f9292729549ade829dcd46bbb84aR1

Good catch. Fixed

jmazanec15
jmazanec15 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vamshin vamshin merged commit 36cac36 into opendistro-for-elasticsearch:master Jul 1, 2020
vamshin added a commit that referenced this pull request Jul 1, 2020
@vamshin
fix release notes versioning (#157)
f345ac1 
* fix release notes versioning
@jmazanec15 jmazanec15 added the Infrastructure Change releated to distribution of plugin label Jul 16, 2020
@jmazanec15 jmazanec15 changed the title fix release notes versioning Fix release notes versioning Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmazanec15 jmazanec15 jmazanec15 approved these changes

Assignees
No one assigned
Labels
Infrastructure Change releated to distribution of plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vamshin @jmazanec15