This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Recall bug fix for odfe>=1.8 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jmazanec15
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
LGTM! Great work finding this fix.
As a note, to confirm that it works, I ran the following test:
- Ingested the SIFT data set from ANN Benchmarks into a single node instance that used the 1.8.0.0 Community AMI with 5 shards and default algorithm settings
- Force merged the index to one segment
- Ran the 10,000 test queries with size and k = 100, and computed recall. Before the fix, recall < 0.75. After the fix, recall > 0.99
jmazanec15
pushed a commit
to jmazanec15/k-NN
that referenced
this pull request
Oct 14, 2020
* recall bug fix for odfe>=1.8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#154
Description of changes:
Details in the issue link above
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.