Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

fix coverage issue #134

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

vamshin
Copy link
Member

@vamshin vamshin commented Jun 9, 2020

Issue #, if available:
#127

Description of changes:
Fix code coverage

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does jnilib a part of this change? Also, what is code coverage before/after making this change?

@vamshin
Copy link
Member Author

vamshin commented Jun 9, 2020

Why does jnilib a part of this change? Also, what is code coverage before/after making this change?

Latest jnilib library build using./gradew build on my mac is different than one in master. We could possibly avoid shipping these libraries as we now have ./gradlew build taking care of building it.

Previously it was around 62% code coverage with fix its 82%.

Detailed current Coverage :-

Element Missed Instructions Cov. Missed Branches Cov. Missed Cxty Missed Lines Missed Methods Missed Classes
com.amazon.opendistroforelasticsearch.knn.index   80%   66% 67 233 95 547 22 148 1 21
com.amazon.opendistroforelasticsearch.knn.index.codec.KNN80Codec   82%   70% 24 69 30 149 11 47 0 9
com.amazon.opendistroforelasticsearch.knn.plugin.transport   68%   100% 16 42 39 101 16 34 0 6
com.amazon.opendistroforelasticsearch.knn.plugin.stats   90%   50% 5 25 8 79 3 21 0 5
com.amazon.opendistroforelasticsearch.knn.index.v1736   86%   58% 5 17 6 43 0 11 0 3
com.amazon.opendistroforelasticsearch.knn.plugin.rest   88%   88% 3 16 3 33 1 7 0 1
com.amazon.opendistroforelasticsearch.knn.plugin   91%   75% 1 15 1 32 0 13 0 3
com.amazon.opendistroforelasticsearch.knn.index.codec   86%   66% 3 9 4 25 1 6 0 3
com.amazon.opendistroforelasticsearch.knn.index.codec.KNN84Codec   90%   100% 2 16 2 20 2 15 0 2
com.amazon.opendistroforelasticsearch.knn.index.util   91%   n/a 1 5 1 8 1 5 1 3
com.amazon.opendistroforelasticsearch.knn.plugin.stats.suppliers   100%   n/a 0 8 0 14 0 8 0 4
Total 929 of 5,273 82% 84 of 280 70% 127 455 189 1,051 57 315 2 60

Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@vamshin vamshin merged commit 4f360f2 into opendistro-for-elasticsearch:master Jun 9, 2020
@vamshin vamshin added the bug label Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants