This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Build separate artifacts for library using CPack #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
changed the title
vamshin
reviewed
May 22, 2020
| dependsOn buildJniLib | ||
| from "$buildDir/jni/release" | ||
| include "*" |
There was a problem hiding this comment.
Minor: Should we specify to just copy the library? Making sure nothing else is copied
There was a problem hiding this comment.
Because the library extension is dependent on Operating System, I used wildcard here. Because only the library is placed in jni/release in the current build process, I believe this operation is okay.
vamshin
approved these changes
May 22, 2020
There was a problem hiding this comment.
LGMT! Thanks for pulling knn library to a separate rpm so that it could be pulled from rpm repo with out having to download from other sources. This was an issue for the users who does not have internet connectivity in their production servers. Thanks for innovating here.
weicongs-amazon
approved these changes
May 22, 2020
jmazanec15
changed the title
chenqi0805
added a commit
to chenqi0805/k-NN
that referenced
this pull request
Jun 9, 2020
* master: added github action to build library artifacts (opendistro-for-elasticsearch#132) FIX: buildDir->rootDir Build separate artifacts for library using CPack (opendistro-for-elasticsearch#123) Fix test structure (opendistro-for-elasticsearch#125)
vamshin
pushed a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#122
Description of changes:
This change uses CPack to generate separate RPM/DEB artifacts for the KNN JNI Library and adds the library as a dependency of the KNN Plugin.
The following steps will build the RPM and DEB packages in the
jni/packagesfolder:2 packages are generated:
Additionally, I changed the directory layout of JNI to follow a more standard C++ convention. The JNI directory now looks like this:
Now, when running
make, it will build the library injni/releaseinstead ofbuildSrc../gradlew buildwill then build the library and move it tobuildSrc.Updated documentation as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.