This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Snapshot Deny List #366
Merged
bowenlan-amzn
merged 5 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:snapshotdenylist
Jan 7, 2021
Merged
Snapshot Deny List #366
bowenlan-amzn
merged 5 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:snapshotdenylist
Jan 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
============================================
+ Coverage 76.21% 76.55% +0.34%
- Complexity 1455 1457 +2
============================================
Files 188 188
Lines 7314 7332 +18
Branches 1186 1187 +1
============================================
+ Hits 5574 5613 +39
+ Misses 1096 1078 -18
+ Partials 644 641 -3 Continue to review full report at Codecov.
|
bowenlan-amzn
added
the
enhancement
An improvement on the existing feature’s functionalities
label
Jan 5, 2021
dbbaughe
reviewed
Jan 5, 2021
...distroforelasticsearch/indexmanagement/indexstatemanagement/settings/ManagedIndexSettings.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 5, 2021
...roforelasticsearch/indexmanagement/indexstatemanagement/step/snapshot/AttemptSnapshotStep.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jan 5, 2021
...roforelasticsearch/indexmanagement/indexstatemanagement/step/snapshot/AttemptSnapshotStep.kt
Outdated
Show resolved
Hide resolved
dbbaughe
approved these changes
Jan 7, 2021
qreshi
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Consume cluster setting
opendistro.index_state_management.snapshot.deny_list
from Runner, pass it to Snapshot Step, will block any snapshot repository if it matches with the prefix in the cluster setting.We cannot directly consume this cluster setting in Snapshot Step, since it is not instantiate when the plugin started, it can only start to consume cluster setting when it's instantiated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.