Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Refactor #336

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Refactor #336

merged 3 commits into from
Nov 16, 2020

Conversation

dbbaughe
Copy link
Contributor

Issue #, if available:

Description of changes:
Updates workflows to upload logs if they fail
Refactors the helper elastic extensions to index management scope to be reusable
Cleans up parser fns
Cleans up notification test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #336 (22c71c5) into master (1d33f4c) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
- Coverage     74.04%   73.93%   -0.11%     
  Complexity     1187     1187              
============================================
  Files           180      180              
  Lines          5994     5973      -21     
  Branches        899      899              
============================================
- Hits           4438     4416      -22     
+ Misses         1090     1089       -1     
- Partials        466      468       +2     
Impacted Files Coverage Δ Complexity Δ
...icsearch/indexmanagement/IndexManagementIndices.kt 62.06% <ø> (ø) 10.00 <0.00> (ø)
...ndexstatemanagement/IndexStateManagementHistory.kt 75.96% <ø> (ø) 27.00 <0.00> (ø)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 61.48% <0.00%> (ø) 35.00 <0.00> (ø)
...dexstatemanagement/elasticapi/ElasticExtensions.kt 94.11% <ø> (+29.00%) 0.00 <0.00> (ø)
...t/indexstatemanagement/model/ManagedIndexConfig.kt 76.53% <ø> (-1.98%) 18.00 <0.00> (ø)
...dexmanagement/indexstatemanagement/model/Policy.kt 89.15% <ø> (-1.07%) 21.00 <0.00> (ø)
...ement/model/coordinator/SweptManagedIndexConfig.kt 81.25% <0.00%> (-5.24%) 8.00 <0.00> (ø)
...exstatemanagement/model/destination/Destination.kt 50.64% <ø> (ø) 9.00 <0.00> (ø)
...anagement/step/allocation/AttemptAllocationStep.kt 79.48% <ø> (ø) 6.00 <0.00> (ø)
...ndexstatemanagement/step/close/AttemptCloseStep.kt 89.58% <ø> (ø) 7.00 <0.00> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d33f4c...c733b70. Read the comment docs.

@dbbaughe dbbaughe merged commit 24be8b7 into opendistro-for-elasticsearch:master Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants