This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Handles remote transport exceptions in rollover #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
- Coverage 74.34% 73.97% -0.38%
+ Complexity 1188 1184 -4
============================================
Files 180 180
Lines 5996 5994 -2
Branches 900 899 -1
============================================
- Hits 4458 4434 -24
- Misses 1074 1094 +20
- Partials 464 466 +2
Continue to review full report at Codecov.
|
bowenlan-amzn
approved these changes
Nov 13, 2020
qreshi
approved these changes
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
dbbaughe
added a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Wasn't correctly handling the remote transport exceptions in rollover which was showing a non so useful message in the cause when it fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.