This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
actionify change policy API #303
Merged
bowenlan-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:security-changepolicy
Oct 9, 2020
Merged
actionify change policy API #303
bowenlan-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:security-changepolicy
Oct 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
============================================
+ Coverage 74.91% 74.95% +0.04%
- Complexity 755 769 +14
============================================
Files 105 108 +3
Lines 4102 4145 +43
Branches 640 642 +2
============================================
+ Hits 3073 3107 +34
- Misses 692 699 +7
- Partials 337 339 +2
Continue to review full report at Codecov.
|
qreshi
previously approved these changes
Oct 8, 2020
dbbaughe
reviewed
Oct 8, 2020
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/ChangePolicy.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Oct 8, 2020
.../amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/StateFilter.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Oct 8, 2020
fun start() { | ||
val getRequest = GetRequest(IndexManagementPlugin.INDEX_MANAGEMENT_INDEX, request.changePolicy.policyID) | ||
|
||
client.get(getRequest, object : ActionListener<GetResponse> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this not work? client.get(getRequest, ActionListener.wrap(::onGetPolicyResponse, ::onFailure))
dbbaughe
reviewed
Oct 8, 2020
...ch/indexmanagement/indexstatemanagement/transport/action/changepolicy/ChangePolicyRequest.kt
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Oct 8, 2020
...amazon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/model/ChangePolicy.kt
Outdated
Show resolved
Hide resolved
dbbaughe
approved these changes
Oct 9, 2020
qreshi
approved these changes
Oct 9, 2020
bowenlan-amzn
added
the
enhancement
An improvement on the existing feature’s functionalities
label
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#292
Description of changes:
actionify add policy API, refactor our API code so we have an action name to each API
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.