-
Notifications
You must be signed in to change notification settings - Fork 45
actionify add policy API #298
actionify add policy API #298
Conversation
add tests ktlint fix
...arch/indexmanagement/indexstatemanagement/transport/action/addpolicy/AddPolicyActionTests.kt
Outdated
Show resolved
Hide resolved
...zon/opendistroforelasticsearch/indexmanagement/indexstatemanagement/util/RestHandlerUtils.kt
Outdated
Show resolved
Hide resolved
...rch/indexmanagement/indexstatemanagement/transport/action/addpolicy/AddPolicyRequestTests.kt
Outdated
Show resolved
Hide resolved
...rch/indexmanagement/indexstatemanagement/transport/action/addpolicy/AddPolicyRequestTests.kt
Outdated
Show resolved
Hide resolved
import com.amazon.opendistroforelasticsearch.indexmanagement.indexstatemanagement.util.FailedIndex | ||
import org.elasticsearch.common.io.stream.StreamInput | ||
|
||
class AddPolicyResponse : ISMStatusResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need a subclass when there is nothing extra being added? Any reason not to just use ISMStatusResponse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big reason, just to look orderly, should be easier to read and understand I guess
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
============================================
+ Coverage 74.88% 74.95% +0.06%
- Complexity 735 747 +12
============================================
Files 100 104 +4
Lines 4050 4076 +26
Branches 636 638 +2
============================================
+ Hits 3033 3055 +22
- Misses 687 688 +1
- Partials 330 333 +3
Continue to review full report at Codecov.
|
Issue #, if available:
#292
Description of changes:
actionify add policy API, refactor our API code so we have an action name to each API
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.