-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish(gry): polish reward model and td error #624
Conversation
fix style for reward model
ding/reward_model/gail_irl_model.py
Outdated
target_new_data_count=64, | ||
# (int) Linear model hidden size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why linear here, there maybe some more complicated networks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because our remodel network is linear, should we change this comment?
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
==========================================
- Coverage 83.03% 82.96% -0.08%
==========================================
Files 570 570
Lines 47037 46955 -82
==========================================
- Hits 39056 38954 -102
- Misses 7981 8001 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 63 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Description
Related Issue
TODO
Check List