Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in reset method #846

Closed
Tracked by #548
neal2164 opened this issue Dec 2, 2024 · 1 comment
Closed
Tracked by #548

Bug in reset method #846

neal2164 opened this issue Dec 2, 2024 · 1 comment
Labels
algo Add new algorithm or improve old one bug Something isn't working

Comments

@neal2164
Copy link

neal2164 commented Dec 2, 2024

pass should be replaced by code like
if hasattr(self._model, 'reset'): return self._model.reset(data_id=data_id, *args, **kwargs)

This bug can cause many issues.

For instance, if a model is first wrapped by the HiddenStatesWrapper then the EpsGreedyWrapper, calling reset method will not reset states.

@neal2164 neal2164 changed the title Bug in reset states Bug in reset method Dec 2, 2024
@PaParaZz1 PaParaZz1 added bug Something isn't working algo Add new algorithm or improve old one labels Dec 2, 2024
@PaParaZz1
Copy link
Member

Thanks for your feedback, we have fixed this problem in the similar way you mentioned. The nesting problem between multiple model wrappers is indeed a challenging matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants