Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick design pass #85

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Quick design pass #85

merged 6 commits into from
Sep 11, 2023

Conversation

lydiascarf
Copy link
Collaborator

@lydiascarf lydiascarf commented Aug 3, 2023

I just wanted to get some of the easy tweaks through to make it look a bit more like the old site. Here's what it looks like:

Screenshot 2023-09-05 at 2 44 46 PM Screenshot 2023-09-05 at 2 46 18 PM Screenshot 2023-09-05 at 2 46 25 PM

@lydiascarf lydiascarf changed the title Redesign Quick design pass Aug 3, 2023
@BryanQuigley
Copy link
Member

It's amazing how much better it looks just with the bg color change.

Everything looks great so far - my only question is why choose a new font?

@BryanQuigley
Copy link
Member

Opened an issue while thinking about it (and it doesn't have to be done here) - but it might be nice to have a button at the top right to get to GitHub.

@lydiascarf lydiascarf mentioned this pull request Sep 5, 2023
@lydiascarf
Copy link
Collaborator Author

It's amazing how much better it looks just with the bg color change.

Everything looks great so far - my only question is why choose a new font?

Thanks!! The font change was to match the old design (see here)

@lydiascarf lydiascarf marked this pull request as ready for review September 5, 2023 18:48
@BryanQuigley BryanQuigley self-requested a review September 5, 2023 22:23
Copy link
Member

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I'm still not getting a marked improvement from the font changes.
Tried removing both of these, and really only seeing a small spacing change, then again I might just be missing it.

@lydiascarf
Copy link
Collaborator Author

@BryanQuigley it's most visible in the header links I think, but it's not drastic

@lydiascarf lydiascarf merged commit a8a895e into main Sep 11, 2023
@lydiascarf lydiascarf deleted the redesign branch September 11, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change organization text from centered to left align Revise home page design
2 participants