Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] revert #8491 #163

Closed
wants to merge 35 commits into from

Conversation

dtrifiro
Copy link

Revert "[Bugfix] Bind api server port before starting engine (vllm-project#8491)"

this causes the http server to always error out:

ERROR:    [Errno 98] error while attempting to bind on address ('0.0.0.0', 8000): address already in use

Isotr0py and others added 30 commits September 13, 2024 06:35
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtrifiro
Copy link
Author

Opened upstream instead

@dtrifiro dtrifiro closed this Sep 17, 2024
Xaenalt pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.