-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] revert #8491 #163
Conversation
Co-authored-by: Yan Ma <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
…ting type annotations (vllm-project#8490)
Co-authored-by: Dipika <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
…llm-project#8509) Signed-off-by: Rui Qiao <[email protected]>
…oject#8491)" This reverts commit 47f5e03.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Opened upstream instead |
Revert "[Bugfix] Bind api server port before starting engine (vllm-project#8491)"
this causes the http server to always error out: