[Sync]: changes from main branch #1603
Merged
+110
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- suspend too many WARNING lines from "make bundle" - remove sample config for components and monitoring Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 4fe5bed)
- add rules for our API components and service which force alias to be named with suffix ctrl Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 32d75a8)
* update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <[email protected]> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <[email protected]> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <[email protected]> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit b0a0f87)
…am (opendatahub-io#1582) * docs: update workflow and how we use two branchs for ODH and downstream - add new doc for how workflow, label on PR, sync process - update branch away from incubatin in github action and reference Signed-off-by: Wen Zhou <[email protected]> * Update docs/sync_code.md Co-authored-by: Gerard Ryan <[email protected]> * revert: branch related test config Signed-off-by: Wen Zhou <[email protected]> * fix: typo Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Gerard Ryan <[email protected]> (cherry picked from commit da75d42)
Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 46d8ba2)
(cherry picked from commit bf8a6e2)
Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit f4c932b)
opendatahub-io#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 768539c)
zdtsw
requested review from
VaishnaviHire
and removed request for
lphiri and
MarianMacik
(cherry picked from commit 2384ada)
|
/test opendatahub-operator-e2e |
|
/test opendatahub-operator-e2e |
|
/test opendatahub-operator-e2e |
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing
|
|
/test opendatahub-operator-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1603 +/- ##
==========================================
+ Coverage 20.02% 20.44% +0.41%
==========================================
Files 160 159 -1
Lines 10977 10806 -171
==========================================
+ Hits 2198 2209 +11
+ Misses 8544 8361 -183
- Partials 235 236 +1 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4a194fc
into
opendatahub-io:rhoai
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria