Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to configure the deployment order of resources #1600

Closed
wants to merge 1 commit into from

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 31, 2025

Description

Relates to https://issues.redhat.com/browse/RHOAIENG-19091

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lburgazzoli. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ykaliuta
Copy link
Contributor

Nice feature!
Will it sort every reconciliation?
May be it makes sense to create a separate sorting caching sorting action (with my PR ;) whose caching key function will be just check of the rr.Generated (plus some logic of handling sorted/unsorted list)?

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 20.15%. Comparing base (fbcf8e7) to head (85368fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
controllers/components/kueue/kueue_controller.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   19.98%   20.15%   +0.17%     
==========================================
  Files         162      162              
  Lines       11010    11029      +19     
==========================================
+ Hits         2200     2223      +23     
+ Misses       8573     8569       -4     
  Partials      237      237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli lburgazzoli marked this pull request as ready for review February 4, 2025 15:44
Copy link

openshift-ci bot commented Feb 4, 2025

@lburgazzoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e fb71033 link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lburgazzoli lburgazzoli marked this pull request as draft February 5, 2025 09:53
@lburgazzoli lburgazzoli removed the request for review from etirelli February 5, 2025 09:53
@lburgazzoli lburgazzoli closed this Feb 8, 2025
@lburgazzoli lburgazzoli deleted the kustomize-up branch February 8, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants