Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: change previous workaround for subscription and add smcp in disable list #1557

Merged
merged 2 commits into from
Jan 23, 2025
Merged

update: change previous workaround for subscription and add smcp in disable list #1557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd5f169
update: change previous workaround for subscription and add smcp in t…
zdtsw Jan 23, 2025
e37588f
Merge branch 'main' into fix_cache_sub_2
zdtsw Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ func main() { //nolint:funlen,maintidx,gocyclo
&rbacv1.RoleBinding{}: {
Namespaces: oDHCache,
},
&ofapiv1alpha1.Subscription{}: {}, // TODO: workaround to get all subs work, without specify it seems it does not cache from all namespaces
&rbacv1.ClusterRole{}: {},
&rbacv1.ClusterRoleBinding{}: {},
&securityv1.SecurityContextConstraints{}: {},
Expand Down Expand Up @@ -302,6 +301,8 @@ func main() { //nolint:funlen,maintidx,gocyclo
Cache: &client.CacheOptions{
DisableFor: []client.Object{
resources.GvkToUnstructured(gvk.OpenshiftIngress),
&ofapiv1alpha1.Subscription{},
resources.GvkToUnstructured(gvk.ServiceMeshControlPlane),
&authorizationv1.SelfSubjectRulesReview{},
},
// Set it to true so the cache-backed client reads unstructured objects
Expand Down
Loading