Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KServe InferenceGraph auth configurations [main] #1491

Merged

Conversation

israel-hdez
Copy link
Contributor

Description

This adds resources required to support auth for KServe InferenceGraphs.

https://issues.redhat.com/browse/RHOAIENG-13449

Other related PRs:

How Has This Been Tested?

  1. Deploy operator
  2. Install KServe
  3. Check that the new resources are present

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This adds resources required to support auth for KServe InferenceGraphs.

Signed-off-by: Edgar Hernández <[email protected]>
@israel-hdez israel-hdez force-pushed the j13449-ig-auth-mesh-configs-main branch from efd2e9b to 9994e38 Compare January 10, 2025 00:29
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@524e4c2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controllers/components/kserve/kserve_support.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage        ?   18.72%           
=======================================
  Files           ?      154           
  Lines           ?    10282           
  Branches        ?        0           
=======================================
  Hits            ?     1925           
  Misses          ?     8145           
  Partials        ?      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 4685177 into opendatahub-io:main Jan 10, 2025
9 of 10 checks passed
@israel-hdez israel-hdez deleted the j13449-ig-auth-mesh-configs-main branch January 10, 2025 15:30
MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-modelmesh-serving-controller-v2-17

chore(deps): update odh-modelmesh-serving-controller-v2-17 to a470727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants