-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable deprecated linters #1475
chore: disable deprecated linters #1475
Conversation
/hold One of the main reasons to create this PR is to have something innocuous to see if the test flakes seen in #1465 are reproducible on main. My guess is that they are. |
@grdryn I'm also seeing similar failures on another PR -1456. There is also a flaky test with infrastructure that shows |
/retest kueue: === RUN TestOdhOperator/validate_installation_of_kueue_component/e2e-test-dsc/Validate_Disabling_Kueue_Component kueue_test.go:75: Error Trace: /go/src/github.com/opendatahub-io/opendatahub-operator/tests/e2e/kueue_test.go:75 Error: Received unexpected error: component Kueue is disabled, should not have deployments in NS opendatahub any more Test: TestOdhOperator/validate_installation_of_kueue_component/e2e-test-dsc/Validate_Disabling_Kueue_Component Messages: error testing kueue component enabled field |
Yeah that one looks different than the test flakes, I haven't seen that one. |
64648de
to
49dae44
Compare
/unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage ? 19.04%
=======================================
Files ? 159
Lines ? 10399
Branches ? 0
=======================================
Hits ? 1980
Misses ? 8195
Partials ? 224 ☔ View full report in Codecov by Sentry. |
/lgtm |
49dae44
to
a4cd34c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lburgazzoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…flux/component-updates/odh-modelmesh-runtime-adapter-v2-17 chore(deps): update odh-modelmesh-runtime-adapter-v2-17 to c0f17b5
Description
How Has This Been Tested?
Before (see warnings):
After (no warnings):
Screenshot or short clip
Merge criteria