Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable deprecated linters #1475

Merged

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Jan 4, 2025


Description

How Has This Been Tested?

Before (see warnings):

➜ make lint
test -s /var/home/gryan/src/github.com/opendatahub-io/opendatahub-operator/bin/golangci-lint || { curl -sSfL 'https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh' | bash -s v1.61.0; }
/var/home/gryan/src/github.com/opendatahub-io/opendatahub-operator/bin/golangci-lint run --timeout=5m0s --sort-results
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. 
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  

After (no warnings):

➜ make lint
test -s /var/home/gryan/src/github.com/opendatahub-io/opendatahub-operator/bin/golangci-lint || { curl -sSfL 'https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh' | bash -s v1.61.0; }
/var/home/gryan/src/github.com/opendatahub-io/opendatahub-operator/bin/golangci-lint run --timeout=5m0s --sort-results

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from CFSNM and lphiri January 4, 2025 00:42
@grdryn
Copy link
Member Author

grdryn commented Jan 4, 2025

/hold

One of the main reasons to create this PR is to have something innocuous to see if the test flakes seen in #1465 are reproducible on main. My guess is that they are.

@biswassri
Copy link
Contributor

One of the main reasons to create this PR is to have something innocuous to see if the test flakes seen in #1465 are reproducible on main. My guess is that they are.

@grdryn I'm also seeing similar failures on another PR -1456. There is also a flaky test with infrastructure that shows { openshift cluster install failed with infrastructure setup} Maybe this is a infrastructure related error?

@grdryn
Copy link
Member Author

grdryn commented Jan 6, 2025

/retest

kueue:

 === RUN   TestOdhOperator/validate_installation_of_kueue_component/e2e-test-dsc/Validate_Disabling_Kueue_Component
    kueue_test.go:75: 
        	Error Trace:	/go/src/github.com/opendatahub-io/opendatahub-operator/tests/e2e/kueue_test.go:75
        	Error:      	Received unexpected error:
        	            	component Kueue is disabled, should not have deployments in NS opendatahub any more
        	Test:       	TestOdhOperator/validate_installation_of_kueue_component/e2e-test-dsc/Validate_Disabling_Kueue_Component
        	Messages:   	error testing kueue component enabled field

@grdryn
Copy link
Member Author

grdryn commented Jan 6, 2025

There is also a flaky test with infrastructure that shows { openshift cluster install failed with infrastructure setup} Maybe this is a infrastructure related error?

Yeah that one looks different than the test flakes, I haven't seen that one.

@grdryn grdryn force-pushed the disable-deprecated-linters branch from 64648de to 49dae44 Compare January 7, 2025 21:10
@grdryn
Copy link
Member Author

grdryn commented Jan 7, 2025

/unhold

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@95f696a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage        ?   19.04%           
=======================================
  Files           ?      159           
  Lines           ?    10399           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8195           
  Partials        ?      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@grdryn grdryn force-pushed the disable-deprecated-linters branch from 49dae44 to a4cd34c Compare January 8, 2025 15:24
@openshift-ci openshift-ci bot removed the lgtm label Jan 8, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2025
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4ba3c22 into opendatahub-io:main Jan 8, 2025
8 checks passed
@grdryn grdryn deleted the disable-deprecated-linters branch January 8, 2025 17:56
MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-modelmesh-runtime-adapter-v2-17

chore(deps): update odh-modelmesh-runtime-adapter-v2-17 to c0f17b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants