Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: chore: use same version of golangci-lint as GHA #1423

Closed
wants to merge 1 commit into from

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Dec 6, 2024

Ignore this until #1422 is merged: it made sense against incubation, but not yet against main

Description

This is a follow up to #1327.

The GitHub action has updated past the version of golangci-lint that
we've specified in the Makefile. This brings them to the same version
to prevent inconsistency (moving to Go 1.22 will introduce such
inconsistency).

The task to install this tool currently doesn't ensure the version, if
it's already in place, so one can to run make -B golangci-lint once
to get the correct versions.

How Has This Been Tested?

➜ ./bin/golangci-lint version
golangci-lint has version 1.60.2 built with go1.23.0 from f338f3ef on 2024-08-20T20:09:03Z

➜ make golangci-lint
make: Nothing to be done for 'golangci-lint'.

➜ make -B golangci-lint
mkdir -p /var/home/gryan/src/github.com/opendatahub-io/opendatahub-operator/bin
{ curl -sSfL 'https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh' | bash -s v1.61.0; }
golangci/golangci-lint info checking GitHub for tag 'v1.61.0'
golangci/golangci-lint info found version: 1.61.0 for v1.61.0/linux/arm64
golangci/golangci-lint info installed ./bin/golangci-lint

➜ ./bin/golangci-lint version
golangci-lint has version 1.61.0 built with go1.23.1 from a1d6c560 on 2024-09-09T17:44:42Z

➜ make golangci-lint
make: Nothing to be done for 'golangci-lint'.

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from grdryn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grdryn grdryn changed the title chore: use same version of golangci-lint as GHA Draft: chore: use same version of golangci-lint as GHA Dec 6, 2024
Copy link

openshift-ci bot commented Dec 6, 2024

@grdryn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e a58b483 link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grdryn
Copy link
Member Author

grdryn commented Dec 6, 2024

/retest

The GitHub action has updated past the version of golangci-lint that
we've specified in the Makefile. This brings them to the same version
to prevent inconsistency (moving to Go 1.22 will introduce such
inconsistency).

The task to install this tool currently doesn't ensure the version, if
it's already in place, so one can to run `make -B golangci-lint` once
to get the correct versions.
@grdryn grdryn force-pushed the golangci-lint-version branch from a58b483 to de60161 Compare December 6, 2024 15:22
@grdryn
Copy link
Member Author

grdryn commented Dec 6, 2024

Seems like this was fixed in #1422

@grdryn grdryn closed this Dec 6, 2024
@grdryn grdryn deleted the golangci-lint-version branch December 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant