-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): set manifestUri as deprecated #1137
base: main
Are you sure you want to change the base?
Conversation
looks good, but I'm not in the list of reviewers :) |
thought i dont need bother you for the docs change :D |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## incubation #1137 +/- ##
=============================================
Coverage ? 19.19%
=============================================
Files ? 30
Lines ? 2683
Branches ? 0
=============================================
Hits ? 515
Misses ? 2106
Partials ? 62 ☔ View full report in Codecov by Sentry. |
d79a068
to
1849500
Compare
- we do not use this for devFlag in DSCI any more - it was used when we still have odh-manifests repo - if use would set devFlags, it should be done in DSC on component base - keep logic still in code but only set warning on API Signed-off-by: Wen Zhou <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria