fix: missing update permission on dashboard object (#1576)

- add update on all cases Signed-off-by: Wen Zhou <[email protected]>
opendatahub-io · Jan 28, 2025 · ca2f619 · ca2f619
1 parent a996732
commit ca2f619
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml b/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml
@@ -106,7 +106,7 @@ metadata:
     categories: AI/Machine Learning, Big Data
     certified: "False"
     containerImage: quay.io/opendatahub/opendatahub-operator:v2.23.1
-    createdAt: "2025-01-27T10:42:46Z"
+    createdAt: "2025-01-28T15:13:51Z"
     olm.skipRange: '>=1.0.0 <2.23.1'
     operators.operatorframework.io/builder: operator-sdk-v1.31.0
     operators.operatorframework.io/internal-objects: '["featuretrackers.features.opendatahub.io",
@@ -536,13 +536,24 @@ spec:
           - console.openshift.io
           resources:
           - consolelinks
+          verbs:
+          - create
+          - delete
+          - get
+          - list
+          - patch
+          - watch
+        - apiGroups:
+          - console.openshift.io
+          resources:
           - odhquickstarts
           verbs:
           - create
           - delete
           - get
           - list
           - patch
+          - update
           - watch
         - apiGroups:
           - controller-runtime.sigs.k8s.io
@@ -659,6 +670,7 @@ spec:
           - get
           - list
           - patch
+          - update
           - watch
         - apiGroups:
           - datasciencecluster.opendatahub.io

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -271,13 +271,24 @@ rules:
   - console.openshift.io
   resources:
   - consolelinks
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - watch
+- apiGroups:
+  - console.openshift.io
+  resources:
   - odhquickstarts
   verbs:
   - create
   - delete
   - get
   - list
   - patch
+  - update
   - watch
 - apiGroups:
   - controller-runtime.sigs.k8s.io
@@ -394,6 +405,7 @@ rules:
   - get
   - list
   - patch
+  - update
   - watch
 - apiGroups:
   - datasciencecluster.opendatahub.io

diff --git a/controllers/datasciencecluster/kubebuilder_rbac.go b/controllers/datasciencecluster/kubebuilder_rbac.go
@@ -136,10 +136,10 @@ package datasciencecluster
 // +kubebuilder:rbac:groups=components.platform.opendatahub.io,resources=dashboards/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=components.platform.opendatahub.io,resources=dashboards/finalizers,verbs=create;get;list;patch;update;use;watch
 // +kubebuilder:rbac:groups="opendatahub.io",resources=odhdashboardconfigs,verbs=create;get;patch;watch;update;delete;list
-// +kubebuilder:rbac:groups="console.openshift.io",resources=odhquickstarts,verbs=create;get;patch;list;delete;watch
-// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=odhdocuments,verbs=create;get;patch;list;delete;watch
-// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=odhapplications,verbs=create;get;patch;list;delete;watch
-// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=acceleratorprofiles,verbs=create;get;patch;list;delete;watch
+// +kubebuilder:rbac:groups="console.openshift.io",resources=odhquickstarts,verbs=create;get;patch;list;delete;watch;update
+// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=odhdocuments,verbs=create;get;patch;list;delete;watch;update
+// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=odhapplications,verbs=create;get;patch;list;delete;watch;update
+// +kubebuilder:rbac:groups="dashboard.opendatahub.io",resources=acceleratorprofiles,verbs=create;get;patch;list;delete;watch;update
 
 // ModelRegistry
 // +kubebuilder:rbac:groups=components.platform.opendatahub.io,resources=modelregistries,verbs=get;list;watch;create;update;patch;delete