Skip to content

Commit

Permalink
add a comment around expectations for the copyGroups function
Browse files Browse the repository at this point in the history
  • Loading branch information
StevenTobin committed Dec 17, 2024
1 parent 595e441 commit 9c70e5b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions controllers/services/auth/auth_controller_actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ func initialize(ctx context.Context, rr *odhtypes.ReconciliationRequest) error {
return nil
}

// We only really expect this to copy once, the fields in the dashboardConfig will be immutable
// but there may be edge cases where the dashboardConfig is created or edited later.
// This function can be removed entirely when the dashboard team deprecates
// the fields in question.
func copyGroups(ctx context.Context, rr *odhtypes.ReconciliationRequest) error {
ai, ok := rr.Instance.(*serviceApi.Auth)
if !ok {
Expand Down

0 comments on commit 9c70e5b

Please sign in to comment.