[RHOAIENG-12726] - odh-model-controller crashes with empty isvc.model field #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… field chore: fix nil pointer if the custom isvc does not have the model field. Signed-off-by: Spolti <[email protected]>
openshift-ci
bot
requested review from
israel-hdez and
VedantMahabaleshwarkar
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spolti, terrytangyuan, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
changed the title
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/odh-model-controller
that referenced
this pull request
Sep 13, 2024
… field (opendatahub-io#264) chore: fix nil pointer if the custom isvc does not have the model field. Signed-off-by: Spolti <[email protected]>
VedantMahabaleshwarkar
added a commit
that referenced
this pull request
Sep 13, 2024
* chore: ensure functions use inherited context (#251) Signed-off-by: Luca Burgazzoli <[email protected]> * Removed and replaced the IstioControlPlaneName and IstioNamespace constants to instead be fetched by env vars. (#254) Signed-off-by: mholder6 <[email protected]> * runtimes: remove distributed executor backend option from vllm (#257) it's the default Signed-off-by: Daniele Trifirò <[email protected]> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263) Signed-off-by: Spolti <[email protected]> * [RHOAIENG-12726] - odh-model-controller crashes with empty isvc.model field (#264) chore: fix nil pointer if the custom isvc does not have the model field. Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Luca Burgazzoli <[email protected]> Signed-off-by: mholder6 <[email protected]> Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Spolti <[email protected]> Co-authored-by: Luca Burgazzoli <[email protected]> Co-authored-by: Mariah Holder <[email protected]> Co-authored-by: Daniele <[email protected]> Co-authored-by: Filippe Spolti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: fix nil pointer if the custom isvc does not have the model field.
Description
How Has This Been Tested?
Merge criteria: