Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InferenceService namespace are not adding into SMMR because issue in Delta identification logic.
odh-model-controller manifest referred in below testing instructions are already contains changes of #110. So by testing this PR, changes of #110 would be verified as well.
How Has This Been Tested?
https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/install-manual.md
oc create -f custom-manifests/opendatahub/kserve-dsc.yaml
cmd. Instead create an instance ofDataScienceCluster
using below CRD:https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/deploy-remove.md
If everything work as mentioned in above step then we are good to go :)
Merge criteria: