Add the grpc route creation option #35
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heyselbi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@heyselbi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // ReconcileRoute will manage the creation, update and deletion of the | ||
| // TLS route when the predictor is reconciled | ||
| // TLS route wheoptionsList[v]n the predictor is reconciled |
| if !createRoute { | ||
| log.Info("Serving runtime does not have 'enable-route' annotation set to 'True'. Skipping route creation") | ||
| return nil | ||
| for _, v := range optionsList { |
There was a problem hiding this comment.
I would prefer extracting the code inside this for to a function, so that you can call inline in the if block that is up these lines avoiding the need for this for loop.
|
Do we still need this PR? |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[RHOAIENG-6877] - odh-model-controller breaks Knative if KServe-Serve…
Description
Addressing RHODS-6401 : https://issues.redhat.com/browse/RHODS-6401
How Has This Been Tested?
The port creation has been tested and is created as expected.
To test it, below are commands to follow in your terminal.
First, an image needs to be build. A personal quay repo can be used if desired --
selbiwill need to change to yours. Alternatively, one can use a ready image that was already build (quay.io/selbi/odh-model-controller:grpc-v3)To re-create the image:
Now deploy the new image with modelmesh-serving. First, login to your cluster (oc login...). **If you skipped image building part and decided to use the ready image, change the image tag from
:grpc-v4to:grpc-v3.Go to your cluster, and make sure that all pods are Running in opendatahub namespace. Or you can check with cli:
Check that the image running in odh-model-controller is the one built earlier:
Now we deploy a sample servingRuntime with sample inferenceService.
Check that two routes are created:
To clean up:
One might ask a great question, does this gRPC port do what a gRPC port is supposed to do (aka does it function as a gRPC port). One can find that answer in another PR: opendatahub-io/modelmesh-serving#106 :)
PS. Ignore the failing openshift-ci. It is not working properly in odh-model-controller overall yet.
Merge criteria: