Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tls to mm deployment for grpc inferencing #106

Closed
wants to merge 3 commits into from

Conversation

heyselbi
Copy link

@heyselbi heyselbi commented Jun 6, 2023

Motivation

https://issues.redhat.com/browse/RHODS-6401
Adding TLS cert-s to mm container for gRPC inferencing

Modifications

TLS cert-s are added to mm container

Result

User can do inferencing with an exposed gRPC port

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link

Jooho commented Jun 9, 2023

openshift-ci for main branch is updated so this PR was failed. The new source will be merged soon and you need to rebase it. Then the fvt test will work properly.

@heyselbi heyselbi marked this pull request as ready for review June 13, 2023 20:22
@openshift-ci openshift-ci bot requested review from anishasthana and Jooho June 13, 2023 20:22
@heyselbi heyselbi changed the base branch from main to release-v0.11.0-alpha June 14, 2023 05:11
@heyselbi heyselbi changed the base branch from release-v0.11.0-alpha to main June 14, 2023 05:12
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

@heyselbi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fvt-odh-manifests 6378bc2 link unknown /test fvt-odh-manifests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@heyselbi heyselbi removed the approved label Jun 14, 2023
@heyselbi heyselbi closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants