-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress e2e Test - Verifies users can create a workbench and inject environment variables during creation #3742
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
=======================================
Coverage 84.24% 84.24%
=======================================
Files 1466 1466
Lines 33780 33780
Branches 9372 9372
=======================================
+ Hits 28457 28458 +1
+ Misses 5323 5322 -1 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor comment, otherwise lgtm.
Good work here @ConorOM1
...sts__/cypress/cypress/tests/e2e/dataScienceProjects/workbenches/testWorkbenchVariables.cy.ts
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
https://issues.redhat.com/browse/RHOAIENG-17424
Description
Migrates ODS-1864 to Cypress
Test is now added to the test script 'testWorkbenchVariables.cy.ts' using an additional 'it' block with some minor changes included
How Has This Been Tested?
An oc login should be performed in the cluster before running the test
test-variables.yml should be configured properly
Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
Tested against ODH-Nightly & RHOAI nightly
How to Run
After exporting the test-variables.yml we have 2 different ways:
Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testWorkbenchVariables.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/workbenches/testWorkbenchVariables.cy.ts" --browser chrome
Test Impact:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main