Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verifies users can create a workbench and inject environment variables during creation #3742

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

ConorOM1
Copy link
Contributor

@ConorOM1 ConorOM1 commented Feb 7, 2025

https://issues.redhat.com/browse/RHOAIENG-17424

Description

Migrates ODS-1864 to Cypress
Test is now added to the test script 'testWorkbenchVariables.cy.ts' using an additional 'it' block with some minor changes included

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test

  • test-variables.yml should be configured properly

  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml

  • Tested against ODH-Nightly & RHOAI nightly

image

How to Run

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testWorkbenchVariables.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/workbenches/testWorkbenchVariables.cy.ts" --browser chrome

Test Impact:

  • This is already a test

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti February 7, 2025 15:12
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (65d30f9) to head (e31043e).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3742   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files        1466     1466           
  Lines       33780    33780           
  Branches     9372     9372           
=======================================
+ Hits        28457    28458    +1     
+ Misses       5323     5322    -1     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d30f9...e31043e. Read the comment docs.

Copy link
Contributor

@antowaddle antowaddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment, otherwise lgtm.

Good work here @ConorOM1

@antowaddle
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2025
@manosnoam manosnoam self-requested a review February 10, 2025 11:25
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 10, 2025
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

New changes are detected. LGTM label has been removed.

@manosnoam manosnoam added the lgtm label Feb 10, 2025
@manosnoam manosnoam merged commit 326c7d9 into opendatahub-io:main Feb 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants