WIP: Adds utils for access checks #3724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andrewballantyne
changed the title
andrewballantyne
requested review from
Gkrumbach07 and
Griffin-Sullivan
and removed request for
alexcreasy and
DaoDaoNoCode
andrewballantyne
commented
Feb 4, 2025
Gkrumbach07
reviewed
Feb 4, 2025
Gkrumbach07
reviewed
Feb 4, 2025
Gkrumbach07
reviewed
Feb 4, 2025
Gkrumbach07
reviewed
Feb 4, 2025
Gkrumbach07
reviewed
Feb 4, 2025
Gkrumbach07
reviewed
Feb 5, 2025
|
New changes are detected. LGTM label has been removed. |
andrewballantyne
force-pushed
the
access-checks
branch
from
9531bef to
86069e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-18732
Description
Adds support for SelfSubjectAccessReviews (SSAR) on resources for admins to help with more granular flows/permissions out of the "admin".
Applies this logic to the Hardware Profiles screen.
Examples of granular permissions:
How Has This Been Tested?
There is a readme in the code that helps with setup for RBAC values on cluster.
Tested around using cluster-admin and impersonating another user with granted permissions.
Test Impact
??
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main