-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API submit logic and enabling feature flag by default #3618
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3618 +/- ##
==========================================
- Coverage 85.16% 84.92% -0.24%
==========================================
Files 1393 1406 +13
Lines 31939 32292 +353
Branches 8955 9055 +100
==========================================
+ Hits 27200 27424 +224
- Misses 4739 4868 +129
... and 75 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks and one actual logic change request (pre-populating the resourceType
). Otherwise, aside from the tests this LGTM!
@ppadti is this still WIP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested whether all radio buttons work with the correct payload and response. A few outstanding scenarios are discussed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good stuff! Awesome to see the feature come together!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-15900
Description
This PR aims to change the API objects created as part of creating/editing a ModelRegistry in order to include the selected or uploaded CA certificate and enabling feature flag by default.
How Has This Been Tested?
Test Impact
I will have followup PR to include cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main