Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API submit logic and enabling feature flag by default #3618

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Jan 7, 2025

Closes: RHOAIENG-15900

Description

This PR aims to change the API objects created as part of creating/editing a ModelRegistry in order to include the selected or uploaded CA certificate and enabling feature flag by default.

How Has This Been Tested?

  1. make sure all the 4 options works correctly while creating/ editing model registry
  2. Also test the creation and updation of MR works when the "Add CA certificate to secure database connection" is not checked.

Test Impact

I will have followup PR to include cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti changed the title API submit logic and enabling feature flag by default [WIP] API submit logic and enabling feature flag by default Jan 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jan 7, 2025
@ppadti ppadti requested review from mturley and removed request for Gkrumbach07 and christianvogt January 7, 2025 13:46
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 40.84507% with 42 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (14b1c4d) to head (3926db9).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
.../modelRegistrySettings/CreateMRSecureDBSection.tsx 0.00% 15 Missing ⚠️
frontend/src/pages/modelRegistrySettings/utils.ts 46.15% 14 Missing ⚠️
...nd/src/pages/modelRegistrySettings/CreateModal.tsx 31.25% 11 Missing ⚠️
.../src/pages/modelRegistrySettings/PemFileUpload.tsx 0.00% 1 Missing ⚠️
...ntend/src/services/modelRegistrySettingsService.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
- Coverage   85.16%   84.92%   -0.24%     
==========================================
  Files        1393     1406      +13     
  Lines       31939    32292     +353     
  Branches     8955     9055     +100     
==========================================
+ Hits        27200    27424     +224     
- Misses       4739     4868     +129     
Files with missing lines Coverage Δ
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
frontend/src/pages/modelRegistrySettings/const.ts 100.00% <100.00%> (ø)
.../src/pages/modelRegistrySettings/PemFileUpload.tsx 3.84% <0.00%> (-0.16%) ⬇️
...ntend/src/services/modelRegistrySettingsService.ts 59.61% <50.00%> (ø)
...nd/src/pages/modelRegistrySettings/CreateModal.tsx 77.77% <31.25%> (-3.31%) ⬇️
frontend/src/pages/modelRegistrySettings/utils.ts 46.15% <46.15%> (ø)
.../modelRegistrySettings/CreateMRSecureDBSection.tsx 7.44% <0.00%> (-5.32%) ⬇️

... and 75 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b1c4d...3926db9. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks and one actual logic change request (pre-populating the resourceType). Otherwise, aside from the tests this LGTM!

@mturley
Copy link
Contributor

mturley commented Jan 8, 2025

@ppadti is this still WIP?

@ppadti ppadti changed the title [WIP] API submit logic and enabling feature flag by default API submit logic and enabling feature flag by default Jan 9, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 9, 2025
@ppadti
Copy link
Contributor Author

ppadti commented Jan 9, 2025

@ppadti is this still WIP?

I am sorry @mturley. I forgot to remove the label here.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested whether all radio buttons work with the correct payload and response. A few outstanding scenarios are discussed here

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! Awesome to see the feature come together!

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4661947 into opendatahub-io:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants