Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete istio resources when istio is disabled, fixes RHOAIENG-5158 #84

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: delete istio resources when istio is disabled, fixes RHOAIENG-5158 #84

merged 3 commits into from
Apr 8, 2024

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Apr 6, 2024 •
edited
Loading

Description

When istio config is missing, delete all istio resources
Fixes RHOAIENG-5158

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb requested a review from tarilabs April 6, 2024 19:06
@dhirajsb dhirajsb force-pushed the fix/delete-istio-resources branch from 2a52044 to c246f0e Compare April 6, 2024 19:11
tarilabs
tarilabs approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I understand this can delete/update selectively the gateway config,
or delete all Istio related resources (incl. gateway)

/lgtm

@dhirajsb dhirajsb merged commit 336f1c2 into opendatahub-io:main Apr 8, 2024
2 checks passed
@dhirajsb dhirajsb deleted the fix/delete-istio-resources branch April 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirajsb @tarilabs