Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update image build and push to handle tags, fixes RHOAIENG-2300 #54

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix: update image build and push to handle tags, fixes RHOAIENG-2300 #54

merged 1 commit into from
Jan 27, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

Renamed workflow file to build-and-push-image.yml
Added steps to handle tags of the form v*

How Has This Been Tested?

Tested locally using github act tool.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb merged commit 8ee954c into opendatahub-io:main Jan 27, 2024
2 checks passed
@dhirajsb dhirajsb deleted the release-workflow branch January 27, 2024 02:30
@tarilabs tarilabs mentioned this pull request Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy Awaiting requested review from rareddy

@tarilabs tarilabs Awaiting requested review from tarilabs

@lampajr lampajr Awaiting requested review from lampajr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhirajsb