Add params.env file for opendatahub-operator install support, fixes #37 #38
Conversation
config/default/kustomization.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Adds namespace to all resources. | |||
| namespace: model-registry-operator-system | |||
| namespace: opendatahub | |||
There was a problem hiding this comment.
I note the operator will move into the ODH namespace operator
There was a problem hiding this comment.
Yes, we have to align it with other odh components, which all use the same namespace.
But, I'll investigate whether we can keep the current kubebuilder default config and use an overlay instead for odh. That way the operator can be used without having to do things the odh way.
| @@ -70,7 +70,7 @@ spec: | |||
| - /manager | |||
| args: | |||
| - --leader-elect | |||
| image: quay.io/opendatahub/model-registry-operator:latest | |||
| image: controller | |||
There was a problem hiding this comment.
I'm wondering however if the images are placed in env file, what is the strategy for the config/manager/kustomization.yaml file, please?
I mean wouldn't that operate some changes which now should pertain to the env file?
(open question)
There was a problem hiding this comment.
Moved odh config to a separate overlay so the default kustomize image override will still work.
|
If possible, I'd hold to merge this after Wednesday, December 6 h17:00 UTC so to give time for the demo to finalize using the current quay image. |
dhirajsb
force-pushed
the
image-params
branch
from
6f960a3 to
e33b5d2
Compare
dhirajsb
force-pushed
the
image-params
branch
from
e33b5d2 to
69d466b
Compare
|
It's ok to merge this now since it's an entirely separate overlay and doesn't affect default operator deployment. |
Description
Add a params.env file and config map generator to load the properties, and kustomize replacement to inject the properties in operator deployment.
How Has This Been Tested?
Tested by deploying locally and verifying config changes are copied from params.env properties.
Merge criteria: