Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating a Route for ModelRegistry http REST service, fixes #19 #29

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Nov 17, 2023

Description

Added template and logic to create an OpenShift Route only if the controller is running in an OpenShift cluster.
Fixes #19

How Has This Been Tested?

Tested by setting the rest spec flag ServiceRoute to enabled in sample model registry manually to verify that Route is created.
Tested Route by using curl against the hostname created by OpenShift.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb requested review from tarilabs and lampajr November 17, 2023 04:10
@dhirajsb dhirajsb changed the title Add support for creating a route for ModelRegistry http REST service, fixes #19 Add support for creating a Route for ModelRegistry http REST service, fixes #19 Nov 17, 2023
@dhirajsb
Copy link
Contributor Author

This only exposes the HTTP endpoint right now, because there are issues with doing the same for gRPC. It appears that the gRPC connection needs to be a secured SSL connection for Routes, and there are issues in SSL configuration in mlmd.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me and matches my understanding of what I created manually during tests:
Screenshot 2023-11-17 at 09 29 05

Thank you!

@dhirajsb dhirajsb merged commit 21f99da into opendatahub-io:main Nov 17, 2023
2 checks passed
@dhirajsb dhirajsb deleted the http-route branch November 17, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Route for UI
3 participants