Explicit model-registry proxy MLMD gRPC port param #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Description
Without explicit params the deployed MR would try to connect to MLMD gRPC to localhost:8081
See: https://github.com/opendatahub-io/model-registry/blob/04aa36605d43a9884b06fb9cd68ce46a14b6b717/cmd/proxy.go#L77-L80
AFTER
Now connects to port 9090 accounting for template values:
How Has This Been Tested?
Ad-hoc built operator in another quay organization and deployed with this change.
Deploys as expected:
NOTE: notice the
I1113 10:05:11.181255 1 proxy.go:34] MLMD server localhost:9090
line, to connect to the expected defaults.Manually created OCP Route (accounting for #19 by defining it manually):
Then can be used:
Merge criteria: