Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit model-registry proxy MLMD gRPC port param #27

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

tarilabs
Copy link
Member

Resolves #26

Description

Without explicit params the deployed MR would try to connect to MLMD gRPC to localhost:8081
See: https://github.com/opendatahub-io/model-registry/blob/04aa36605d43a9884b06fb9cd68ce46a14b6b717/cmd/proxy.go#L77-L80

AFTER

Now connects to port 9090 accounting for template values:

How Has This Been Tested?

Ad-hoc built operator in another quay organization and deployed with this change.
Deploys as expected:

Screenshot 2023-11-13 at 11 16 24 Screenshot 2023-11-13 at 11 16 40

NOTE: notice the I1113 10:05:11.181255 1 proxy.go:34] MLMD server localhost:9090 line, to connect to the expected defaults.

Manually created OCP Route (accounting for #19 by defining it manually):
Screenshot 2023-11-13 at 11 29 46

Then can be used:
Screenshot 2023-11-13 at 11 17 48

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@tarilabs tarilabs requested a review from a team November 13, 2023 10:34
@dhirajsb dhirajsb self-requested a review November 13, 2023 16:12
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dhirajsb dhirajsb force-pushed the tarilabs-20231113-grpcPort branch from 7302e0f to 24a00bc Compare November 13, 2023 16:12
@dhirajsb dhirajsb merged commit 6dc0996 into opendatahub-io:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align model-registry proxy cmd defaults to template defaults
2 participants