fix: use groups and username from tokenreview auth step in authconfig, fixes RHOAIENG-16025 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fixes RHOAIENG-16025 Signed-off-by: Dhiraj Bokde <[email protected]>
…nstructured type for AuthConfig to avoid authorino golang dependecy issues Signed-off-by: Dhiraj Bokde <[email protected]>
dhirajsb
force-pushed
the
fix/authconfig-groups
branch
from
b7c8115 to
1582d13
Compare
lugi0
reviewed
Nov 25, 2024
lugi0
reviewed
Nov 25, 2024
|
@Al-Pragliola once @lugi0 marks his questions as resolved, we can squash and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use groups and username from tokenreview auth step in authconfig
Fixes RHOAIENG-16025
Requires merging and releasing Authorino fix first at Kuadrant/authorino#506
Fix for which is in the PR Kuadrant/authorino#507
How Has This Been Tested?
Merge criteria: