Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ConfigurationError reason to Available condition by checking mlmd log, fixes RHOAIENG-11328 #151

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

Add new reason ConfigurationError to Available condition by checking mlmd log
Fixes RHOAIENG-11328

How Has This Been Tested?

Tested locally by using an invalid hostname for db, which causes the new reason to show up with mlmd log error message.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb requested a review from a team October 24, 2024 17:52
@dhirajsb dhirajsb marked this pull request as draft October 24, 2024 17:52
@dhirajsb
Copy link
Contributor Author

Hold off on merging this wip PR.

@dhirajsb dhirajsb marked this pull request as ready for review November 5, 2024 00:37
@dhirajsb
Copy link
Contributor Author

dhirajsb commented Nov 5, 2024

@Al-Pragliola please review it to be merged in 2.16 this week, thanks

@dhirajsb dhirajsb force-pushed the feat/status-db-errors branch from 5798007 to 62d39cd Compare November 5, 2024 18:11
@dhirajsb dhirajsb merged commit 57094ff into opendatahub-io:main Nov 7, 2024
2 checks passed
@dhirajsb dhirajsb deleted the feat/status-db-errors branch November 7, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant