Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for configmap CA certs, fixes RHOAIENG-14601 #148

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

Add support for configmap CA certs
Fixes RHOAIENG-14601

How Has This Been Tested?

Changed secure-db sample to use configmap for CA, and tested deployment in local cluster

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb force-pushed the feat/configmap-certs branch from 325b640 to 76d61b0 Compare October 17, 2024 00:13
@dhirajsb
Copy link
Contributor Author

Depends on merging #147 first

@tarilabs tarilabs requested a review from a team October 17, 2024 08:51
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand a configmap is created for holding the root CA used for the DB certificates.

I understand this is now a parameter in the MR CR,
so that the operator can use (when provided) the CM to mount the root CA -- which then MLMD can use to communicate with the DB

In general,
/lgtm

is this the way also DSP is doing this? I saw some slack threads but was not there for the conclusion

Thank you!

@dhirajsb
Copy link
Contributor Author

@tarilabs yes, DSP also uses configmap, but its not something they expose to users in the Dashboard right now.

@dhirajsb dhirajsb force-pushed the feat/configmap-certs branch from 76d61b0 to 402769b Compare October 17, 2024 16:15
Copy link
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhirajsb dhirajsb merged commit e0ead0b into opendatahub-io:main Oct 17, 2024
2 checks passed
@dhirajsb dhirajsb deleted the feat/configmap-certs branch October 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants