Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup optional properties, fixes RHOAIENG-12838 #132

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

General cleanup optional properties
Fixes RHOAIENG-12838

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb force-pushed the fix/optional-properties branch from 3645116 to 46aaf41 Compare September 12, 2024 20:04
@dhirajsb
Copy link
Contributor Author

@Al-Pragliola please review
@tarilabs let's get this fix into this weeks (Sep13) release.

Copy link
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dhirajsb dhirajsb merged commit 637ed69 into opendatahub-io:main Sep 12, 2024
2 checks passed
@dhirajsb dhirajsb deleted the fix/optional-properties branch September 12, 2024 21:14
rareddy pushed a commit to rareddy/model-registry-operator that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants