Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing DB labels in DB secrets, fixes RHOAIENG-12126 #129

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: add missing DB labels in DB secrets, fixes RHOAIENG-12126 #129

merged 1 commit into from
Aug 30, 2024

Conversation

dhirajsb
Copy link
Contributor

Description

Added missing DB labels in DB secrets, without which sample DB cannot be deloyed using a label filter.
Fixes RHOAIENG-12126

How Has This Been Tested?

Used the following command in a new namespace to create a test DB:

oc apply -k config/samples/secure-db/mysql/ -l app.kubernetes.io/name=model-registry-db

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

rareddy
rareddy approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dhirajsb dhirajsb merged commit 033afb2 into opendatahub-io:main Aug 30, 2024
2 checks passed
@dhirajsb dhirajsb deleted the fix/db-secret-labels branch August 30, 2024 23:13
rareddy pushed a commit to rareddy/model-registry-operator that referenced this pull request Oct 1, 2024
@dhirajsb @rareddy
fix: add missing DB labels in DB secrets, fixes RHOAIENG-12126 (opend…
1fe96da 
…atahub-io#129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@tarilabs tarilabs Awaiting requested review from tarilabs

@Al-Pragliola Al-Pragliola Awaiting requested review from Al-Pragliola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirajsb @rareddy