Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openshift serving certs to metrics endpoint, fixes RHOAIENG-1828 #120

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Aug 2, 2024

Description

Add openshift serving certs to metrics endpoint
Fixes RHOAIENG-1828

How Has This Been Tested?

Locally applied the generated ODH config from the ODH overlay and verified the following:

  • Cert secret name is correct in the service annotation
  • Serving cert is created
  • Cert secret name is correct in the auth proxy volume secretName
  • Cert is loaded by operator in auth-proxy container

Verified metrics can be retrieved after creating clusterrolebinding from another pod serviceaccount to metrics-reader role.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb requested a review from tarilabs August 2, 2024 04:17
@dhirajsb
Copy link
Contributor Author

dhirajsb commented Aug 2, 2024

@tarilabs need to merge this before creating the next MR release for ODH 2.16

@tarilabs tarilabs requested a review from a team August 2, 2024 09:01
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks Dhiraj

@tarilabs
Copy link
Member

tarilabs commented Aug 3, 2024

@dhirajsb you wanted me to perform the release train of MR by Monday, but seems this one is holding the release based on your #120 (comment).
Please advise.

@dhirajsb dhirajsb merged commit 8c1505c into opendatahub-io:main Aug 3, 2024
2 checks passed
@dhirajsb dhirajsb deleted the feat/metrics-cert branch August 3, 2024 18:55
@dhirajsb
Copy link
Contributor Author

dhirajsb commented Aug 3, 2024

@tarilabs merged this change since I was waiting on a platform PR merge as well. We are ok to do the MR release now.

rareddy pushed a commit to rareddy/model-registry-operator that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants